> On Sept. 24, 2014, 11:39 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 743-744 > > <https://reviews.apache.org/r/25866/diff/3/?file=700961#file700961line743> > > > > Why do we check slave->connected before calling disconnect below, but > > we don't check framework->connected here? > > > > Probably warrants a comment.
this was done as part of MESOS-675 (by you :)). Added a comment. > On Sept. 24, 2014, 11:39 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 1653-1666 > > <https://reviews.apache.org/r/25866/diff/3/?file=700961#file700961line1653> > > > > Should this be below deactivateFramework, to keep disconnect and > > deactivate adjacent (like in the header file)? done. > On Sept. 24, 2014, 11:39 p.m., Ben Mahler wrote: > > src/master/master.cpp, line 1655 > > <https://reviews.apache.org/r/25866/diff/3/?file=700961#file700961line1655> > > > > Re: question above > > > > Should this be idempotent? i.e. do nothing when already disconnected. > > > > Or do you want the caller to never call this when already disconnected? yup, the latter, esp when calling methods that take pointers. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54384 ----------------------------------------------------------- On Sept. 22, 2014, 11:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25866/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 11:50 p.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1081 and MESOS-1811 > https://issues.apache.org/jira/browse/MESOS-1081 > https://issues.apache.org/jira/browse/MESOS-1811 > > > Repository: mesos-git > > > Description > ------- > > Made consistent what connected and active frameworks/slaves means. > > Fixed MESOS-1811 along the way. > > > Diffs > ----- > > src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 > src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 > src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 > src/tests/fault_tolerance_tests.cpp > 154386044d0247b39d84719d7ff14250682a0695 > src/tests/master_tests.cpp 8e4ec1d85c4530b5421387de55036f7d40ee3180 > > Diff: https://reviews.apache.org/r/25866/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
