----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review55674 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96039> ``` static list<Option<CommandInfo>> accumulate( ``` src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96038> ``` static Future<list<Option<CommandInfo>>> _prepare( ``` src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96041> ``` const list<Option<CommandInfo>> commands ```` Since `lambda::bind` will do the copy anyway. src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96047> static s/_return/_cleanup/ src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96046> static src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96049> What's the purpose of that? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96045> See comments in the other patch. src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment96044> Can you use f.onAny here so that you don't need to change the signature of `___destroy`? - Jie Yu On Oct. 3, 2014, 5:05 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25861/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2014, 5:05 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Change from doing in parallel and collect()ing to serial according to the > vector of isolators (reversed order for cleanup). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > bf246ca649ca4a461cebf1aee6908a2d58eec362 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > > Diff: https://reviews.apache.org/r/25861/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
