----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review57407 -----------------------------------------------------------
Ship it! LGTM. Please add a comment about why ```isolate``` calls are done in parallel. src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment98103> Move this right above ```__destroy```. src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment98106> Since it's not possible, could you just use a CHECK_READY here? src/slave/containerizer/mesos/containerizer.cpp <https://reviews.apache.org/r/25861/#comment98107> No need? - Jie Yu On Oct. 20, 2014, 6:49 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25861/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 6:49 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Change from doing in parallel and collect()ing to serial according to the > vector of isolators (reversed order for cleanup). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > bf246ca649ca4a461cebf1aee6908a2d58eec362 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > > Diff: https://reviews.apache.org/r/25861/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
