> On Oct. 14, 2014, 1:51 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 1022 > > <https://reviews.apache.org/r/25861/diff/3/?file=721061#file721061line1022> > > > > Not sure if I'm missing something, but if you chain all lambdas with > > .then, only the last one will be the failed one right?
The chaining is on the outer Future<list<Future>> which accumulates the individual Futures when they are [ready|failed|discarded], not the futures themselves. I want cleanup to be called on each isolator, regardless of the success of preceeding isolators. The list can contain any ordering of futures in any !pending state. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25861/#review56569 ----------------------------------------------------------- On Oct. 14, 2014, 1:34 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25861/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2014, 1:34 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Change from doing in parallel and collect()ing to serial according to the > vector of isolators (reversed order for cleanup). > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > bf246ca649ca4a461cebf1aee6908a2d58eec362 > src/slave/containerizer/mesos/containerizer.cpp > 9d083294caa5c5a47ba3ceaa1b57346144cb795c > > Diff: https://reviews.apache.org/r/25861/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
