> On Jan. 27, 2015, 2:06 p.m., Bernd Mathiske wrote: > > src/tests/master_allocator_tests.cpp, line 80 > > <https://reviews.apache.org/r/29927/diff/2/?file=826946#file826946line80> > > > > And how does the comment relate to this method? It seems to imply that > > calling this method has said effect, but that's too indirectly put in a > > conditional phrase. > > > > Alternatively you can move the comment into the method. Then it is > > pretty clear what it pertains to.
The comment describes why we need this method. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/#review69787 ----------------------------------------------------------- On Jan. 27, 2015, 3:23 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29927/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 3:23 p.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > Several tests have been reported flaky if allocation is not ceased explicitly > (see MESOS-1677). To stop allocation, an allocator instance should be > destroyed. To facilitate this, store a pointer to a MockAllocator instance in > the MasterAllocatorTest fixture and let a test case destroy it. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp 2430622 > > Diff: https://reviews.apache.org/r/29927/diff/ > > > Testing > ------- > > make check (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
