Yes, it makes sense. I've seen your patches for MESOS-2232, they should remove the necessity for this request
On Fri, Jan 16, 2015 at 9:08 PM, Benjamin Mahler <benjamin.mah...@gmail.com> wrote: > It seems like this may become unnecessary as I fix MESOS-2232. Could you > hold off on this one? > > On Fri, Jan 16, 2015 at 11:41 AM, Benjamin Mahler < > benjamin.mah...@gmail.com> wrote: > >> That review doesn't describe what the issue was, unfortunately. And the >> ticket is a bit vague. >> >> Is it about uninteresting mock calls? Do we want to change our mocking >> approach to avoid the uninteresting mock calls? Note that most of our other >> mocks do not have uninteresting calls because we used EXPECT_CALL instead >> of ON_CALL: >> >> >> https://github.com/apache/mesos/blob/0.21.1/src/tests/containerizer.cpp#L220 >> >> The only mock that still uses ON_CALL is the allocator mock, IIRC: >> >> https://github.com/apache/mesos/blob/0.21.1/src/tests/mesos.hpp#L654 >> >> I can't recall if there was a reason for this, but it would be nice to >> end the madness. Hope this helps. >> >> >> On Fri, Jan 16, 2015 at 5:08 AM, Alexander Rukletsov <a...@mesosphere.io> >> wrote: >> >>> >>> >>> > On Jan. 15, 2015, 8:12 p.m., Ben Mahler wrote: >>> > > Yikes, could you elaborate on what the issue was? >>> >>> Based on this commit: b4bd08693f394a196e0310955b1afdfbe3c2de36, >>> https://reviews.apache.org/r/24418 >>> >>> >>> - Alexander >>> >>> >>> ----------------------------------------------------------- >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/29927/#review68310 >>> ----------------------------------------------------------- >>> >>> >>> On Jan. 15, 2015, 4:58 p.m., Alexander Rukletsov wrote: >>> > >>> > ----------------------------------------------------------- >>> > This is an automatically generated e-mail. To reply, visit: >>> > https://reviews.apache.org/r/29927/ >>> > ----------------------------------------------------------- >>> > >>> > (Updated Jan. 15, 2015, 4:58 p.m.) >>> > >>> > >>> > Review request for mesos, Bernd Mathiske and Niklas Nielsen. >>> > >>> > >>> > Bugs: MESOS-2213 >>> > https://issues.apache.org/jira/browse/MESOS-2213 >>> > >>> > >>> > Repository: mesos-git >>> > >>> > >>> > Description >>> > ------- >>> > >>> > Several tests have been reported flaky if allocator is not stopped >>> explicitly in some cases. Since allocators are not tied to the >>> AllocatorProcess any more, provide a method in Allocator to cease >>> allocation. >>> > >>> > >>> > Diffs >>> > ----- >>> > >>> > src/allocation/allocator.hpp PRE-CREATION >>> > src/tests/master_allocator_tests.cpp 2430622 >>> > src/tests/mesos.hpp 591134b >>> > >>> > Diff: https://reviews.apache.org/r/29927/diff/ >>> > >>> > >>> > Testing >>> > ------- >>> > >>> > make check (Ubuntu, OS X) >>> > >>> > >>> > Thanks, >>> > >>> > Alexander Rukletsov >>> > >>> > >>> >>> >> >
