----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/#review68720 -----------------------------------------------------------
The resolution here is to keep the original behaviour, but not introduce a public method in `Allocator` interface, but reuse the destructor. - Alexander Rukletsov On Jan. 15, 2015, 4:58 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29927/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 4:58 p.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > Several tests have been reported flaky if allocator is not stopped explicitly > in some cases. Since allocators are not tied to the AllocatorProcess any > more, provide a method in Allocator to cease allocation. > > > Diffs > ----- > > src/allocation/allocator.hpp PRE-CREATION > src/tests/master_allocator_tests.cpp 2430622 > src/tests/mesos.hpp 591134b > > Diff: https://reviews.apache.org/r/29927/diff/ > > > Testing > ------- > > make check (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
