----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29927/#review69318 -----------------------------------------------------------
One question below. Otherwise, looks good! :) src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/29927/#comment113980> Can we to guard this so you capture dispatches to a 'stopped' allocator upfront? - Niklas Nielsen On Jan. 20, 2015, 10:10 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29927/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 10:10 a.m.) > > > Review request for mesos, Bernd Mathiske and Niklas Nielsen. > > > Bugs: MESOS-2213 > https://issues.apache.org/jira/browse/MESOS-2213 > > > Repository: mesos-git > > > Description > ------- > > Several tests have been reported flaky if allocation is not ceased explicitly > (see MESOS-1677). To stop allocation, an allocator instance should be > destroyed. To facilitate this, store a pointer to a MockAllocator instance in > the MasterAllocatorTest fixture and let a test case destroy it. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp 2430622 > > Diff: https://reviews.apache.org/r/29927/diff/ > > > Testing > ------- > > make check (Ubuntu, OS X) > > > Thanks, > > Alexander Rukletsov > >
