> On April 14, 2015, 2:16 p.m., Alexander Rukletsov wrote: > > src/authentication/cram_md5/authenticatee.cpp, lines 46-47 > > <https://reviews.apache.org/r/32850/diff/3/?file=922370#file922370line46> > > > > Let's move to newline to avoid jaggeddness. Btw, what does clang-format > > suggest? > > Kapil Arya wrote: > According to our style guide, this is okay but we keep seeing issues > being raised about this. Should we just update the style guide instead? > > Alexander Rukletsov wrote: > I would like to have just one way of doing this. I think the one with > newline scales better. > > Till Toenshoff wrote: > This was exactly clang-format's suggestion. Raised > https://issues.apache.org/jira/browse/MESOS-2618
Sorry about that, `clang-format` gets this "wrong" currently. It's documented under [Known Limitations](https://github.com/apache/mesos/blob/master/docs/clang-format.md#known-limitations). - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/#review80020 ----------------------------------------------------------- On April 15, 2015, 12:44 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32850/ > ----------------------------------------------------------- > > (Updated April 15, 2015, 12:44 a.m.) > > > Review request for mesos, Adam B, Joris Van Remoortere, and switched to > 'mcypark'. > > > Bugs: MESOS-2584 > https://issues.apache.org/jira/browse/MESOS-2584 > > > Repository: mesos-incubating > > > Description > ------- > > Removing the process from the header is much cleaner and also fixes the > linked clang 3.4.2 JIRA. Apart from that moving, no code is changed. > > > Diffs > ----- > > src/Makefile.am d15a373 > src/authentication/cram_md5/authenticatee.hpp 55fac68 > src/authentication/cram_md5/authenticatee.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/32850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
