> On April 14, 2015, 6:17 p.m., Joerg Schad wrote: > > src/authentication/cram_md5/authenticatee.cpp, line 33 > > <https://reviews.apache.org/r/32850/diff/4/?file=927033#file927033line33> > > > > Actually according to Google's styleguide this should be the first > > include, shouldn't it? > > > > http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Names_and_Order_of_Includes > > > > I know we don't do that at other places but actually it would prevent a > > number of Alexs comments (and be consistent with the styleguide)...
I think we don't follow google styleguide whe including headers (update the styleguide?), we have our own grouping: by project, by directory, alphabetically. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/#review80072 ----------------------------------------------------------- On April 14, 2015, 2:20 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32850/ > ----------------------------------------------------------- > > (Updated April 14, 2015, 2:20 p.m.) > > > Review request for mesos, Adam B, Joris Van Remoortere, and switched to > 'mcypark'. > > > Bugs: MESOS-2584 > https://issues.apache.org/jira/browse/MESOS-2584 > > > Repository: mesos-incubating > > > Description > ------- > > Removing the process from the header is much cleaner and also fixes the > linked clang 3.4.2 JIRA. Apart from that moving, no code is changed. > > > Diffs > ----- > > src/Makefile.am d15a373 > src/authentication/cram_md5/authenticatee.hpp 55fac68 > src/authentication/cram_md5/authenticatee.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/32850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
