----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32850/#review80018 -----------------------------------------------------------
Ship it! LGTM assuming the changes only involve code move only :-). src/authentication/cram_md5/authenticatee.hpp <https://reviews.apache.org/r/32850/#comment129768> I think this `#include` can be moved to the cpp file as well. - Kapil Arya On April 9, 2015, 10:58 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32850/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 10:58 p.m.) > > > Review request for mesos, Adam B, Joris Van Remoortere, and switched to > 'mcypark'. > > > Bugs: MESOS-2584 > https://issues.apache.org/jira/browse/MESOS-2584 > > > Repository: mesos-incubating > > > Description > ------- > > Removing the process from the header is much cleaner and also fixes the > linked clang 3.4.2 JIRA. Apart from that moving, no code is changed. > > > Diffs > ----- > > src/Makefile.am fa609da > src/authentication/cram_md5/authenticatee.hpp 55fac68 > src/authentication/cram_md5/authenticatee.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/32850/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
