arjansh commented on a change in pull request #240: METAMODEL-1225 Add
ColumnTypingStrategies and use them in CSV module.
URL: https://github.com/apache/metamodel/pull/240#discussion_r408842991
##########
File path:
csv/src/test/java/org/apache/metamodel/csv/SingleLineCsvDataSetTest.java
##########
@@ -64,4 +70,84 @@ public void testMalformedLineParsing() throws Exception {
assertFalse(ds.next());
ds.close();
}
-}
\ No newline at end of file
+
+ public void testCustomTyping() throws Exception {
+ ColumnType columnType1 = ColumnType.DATE;
Review comment:
Same here as above. In my opinion just using the constant is more clear than
adding it to a variable which doesn't add a meaning to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
