LiveSatomi commented on a change in pull request #240: METAMODEL-1225 Add ColumnTypingStrategies and use them in CSV module. URL: https://github.com/apache/metamodel/pull/240#discussion_r408913492
########## File path: core/src/main/java/org/apache/metamodel/schema/typing/ColumnTypingContextImpl.java ########## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.metamodel.schema.typing; + +import org.apache.metamodel.schema.ColumnType; +import org.apache.metamodel.schema.Table; + + +/** + * An implementation of {@link ColumnTypingContext} that holds necessary context about the column being configured. + */ +public class ColumnTypingContextImpl implements ColumnTypingContext { + + private final int columnIndex; + + private final Table table; + + + /** + * Creates a context to conifgure a column for a specific table. + * @param table The table that contains the column + * @param columnIndex the index in the table of the column being configured. + */ + public ColumnTypingContextImpl( Table table, int columnIndex ) { Review comment: I will go back and double check the space padding in the rest of the files. My work uses different formatting rules and I'm not used to handling multiple rulesets in my IDE. I agree with making parameters final when possible. Does this also apply to parameters of lambda functions? for example an instance of the ColumnTypingSession after adding the default implementation to close: ``` return (final ColumnTypingContext ctx) -> { if ( iterator.hasNext() ) { return iterator.next(); } return null; }; ``` or ``` return ctx -> { if ( iterator.hasNext() ) { return iterator.next(); } return null; }; ``` Personally I treat parameters as final whether they are marked as such or not, and I don't see any final lambda parameters in the project so far. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
