Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/832#discussion_r149426981
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -234,26 +366,43 @@ public synchronized void init(AccessConfig config) {
if(this.client == null) {
this.client =
ElasticsearchUtils.getClient(config.getGlobalConfigSupplier().get(),
config.getOptionalSettings());
this.accessConfig = config;
+ this.columnMetadataDao = new
ElasticsearchColumnMetadataDao(this.client.admin(),
Collections.singletonList(".kibana"));
--- End diff --
Yes, I agree with your feedback. I was just trying to refactor the column
metadata logic and minimize other changes. So in this case `.kibana` was
already hard-coded in ElasticsearchDao.
I would be totally open to making this improvement though. I was just
trying to walk the line of how much should I change when refactoring?
Considering that, what do you think?
---
