Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/832#discussion_r149428796
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -234,26 +366,43 @@ public synchronized void init(AccessConfig config) {
if(this.client == null) {
this.client =
ElasticsearchUtils.getClient(config.getGlobalConfigSupplier().get(),
config.getOptionalSettings());
this.accessConfig = config;
+ this.columnMetadataDao = new
ElasticsearchColumnMetadataDao(this.client.admin(),
Collections.singletonList(".kibana"));
--- End diff --
I'm almost always in favor of having hard coded things passed in via config
files. It gets us out of jams and almost every time I've convinced myself that
it's not necessary, it totally is. How convinced are you that we are only ever
going to need one ignored index?
If you have doubts, then I'd probably add something to the
`application.yml` which gets set in the AccessConfig object when we set up the
index in the IndexConfig from `metron-rest`.
---
