Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/832#discussion_r149429061
  
    --- Diff: 
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
 ---
    @@ -234,26 +366,43 @@ public synchronized void init(AccessConfig config) {
         if(this.client == null) {
           this.client = 
ElasticsearchUtils.getClient(config.getGlobalConfigSupplier().get(), 
config.getOptionalSettings());
           this.accessConfig = config;
    +      this.columnMetadataDao = new 
ElasticsearchColumnMetadataDao(this.client.admin(), 
Collections.singletonList(".kibana"));
    --- End diff --
    
    Given that it's a pretty simple change and requires no new machinery to 
added, I think it is probably a good fit to add to this PR, but I might be on 
the wrong side of that line more than I'm on the right side, so take my word 
with a grain of salt. ;)


---

Reply via email to