Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/832#discussion_r149428276
--- Diff:
metron-platform/metron-elasticsearch/src/main/java/org/apache/metron/elasticsearch/dao/ElasticsearchDao.java
---
@@ -234,26 +366,43 @@ public synchronized void init(AccessConfig config) {
if(this.client == null) {
this.client =
ElasticsearchUtils.getClient(config.getGlobalConfigSupplier().get(),
config.getOptionalSettings());
this.accessConfig = config;
+ this.columnMetadataDao = new
ElasticsearchColumnMetadataDao(this.client.admin(),
Collections.singletonList(".kibana"));
--- End diff --
Ok, man I have been really bad about reading and comprehension today. I
see in your review comment feedback that you already addressed this point.
Sorry.
I think having this hardcoded is just not good. The change seems simple
enough. I can probably take care of this no problem.
---
