Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/824
The 2nd most recent commits updates the MetaAlertDao interface by adding
additional methods for interacting with metaalerts. This should make it
easier to use and make the underlying implementation simpler and easier to
understand by eliminating the need for complex logic that must catch all of the
different use cases in the MetaAlertDao.update. The high-level changes include:
- dedicated methods that allow adding/removing alerts to/from a metaalert
- dedicated method for changing the status of a metaalert
- direct updates through IndexDao.update are no longer allowed on
metaalerts, the other MetaAlertDao methods must be used instead
The latest commit updates the ElasticsearchMetaAlertIntegrationTest with
several changes:
- test data setup and test style is now consistent across all tests
- test cases for the new interface methods were added
- old test cases were reconciled with the new test cases
- test coverage for ElasticsearchMetaAlertDao is now close to 100% with
tests added for all the bugs found so far
I am still working on adding these changes:
- updated javadocs and comments in all relevant classes and tests
- an HBaseDao.getAllLatest implementation and test
- updated ElasticsearchMetaAlertDaoTest adapted for the new MetaAlertDao
interface (it's currently all commented out for the purpose of running the
integration tests)
For now reviewers can start looking at the new MetaAlertDao interface
methods and the accompanying integration tests in
ElasticsearchMetaAlertIntegrationTest. Hope to have the rest pushed out soon.
---
