Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/824
  
    The latest commits address some outstanding tasks and address a couple 
other issues:
    - disabling updates to meta alert objects means we can't update a meta 
alert name or comments (or other fields that may be added in the future).  The 
patch implementation was added to the ElasticsearchMetaAlertDao to allow 
updates to fields other than `alert` and `status` which require special 
handling and have dedicated endpoints
    - a `getAllLatest` implementation was added to the HBaseDao along with an 
integration test
    - a bug was discovered where the number of search results returned defaults 
to 10 meaning changes to alerts are only propagated to the first 10 meta alerts 
and vice-versa.  This was corrected in the ElasticsearchDao.searchByGuids by 
explicitly setting the size and fixed in the alert/meta alert lookup queries by 
paging through all the results if necessary.  A test was added to the 
integration test to catch this case in the future.
    
    I feel like this PR is in pretty good shape from a functional perspective.  
Still working on javadocs/documentation but it's ready for functional 
testing/code review.
    



---

Reply via email to