Github user cestella commented on a diff in the pull request:

    https://github.com/apache/metron/pull/824#discussion_r150638251
  
    --- Diff: 
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java
 ---
    @@ -200,4 +207,23 @@ public MetaAlertCreateResponse 
createMetaAlert(MetaAlertCreateRequest request)
         createResponse.setCreated(true);
         return createResponse;
       }
    +
    +  @Override
    +  public boolean addAlertsToMetaAlert(String metaAlertGuid, 
Collection<String> alertGuids,
    +      Collection<String> sensorTypes) throws IOException {
    +    return true;
    --- End diff --
    
    Given the non-implementation of these, do we not have any integration tests 
in metron-rest exercising the add/remove alerts calls?


---

Reply via email to