Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/824#discussion_r150644110
--- Diff:
metron-platform/metron-indexing/src/test/java/org/apache/metron/indexing/dao/InMemoryMetaAlertDao.java
---
@@ -200,4 +207,23 @@ public MetaAlertCreateResponse
createMetaAlert(MetaAlertCreateRequest request)
createResponse.setCreated(true);
return createResponse;
}
+
+ @Override
+ public boolean addAlertsToMetaAlert(String metaAlertGuid,
Collection<String> alertGuids,
+ Collection<String> sensorTypes) throws IOException {
+ return true;
--- End diff --
I think @cestella's suggestion is good, I will add some REST integration
tests that ensure request/responses are serialized/deserialized correctly.
There are tests included in MetaAlertControllerIntegrationTest that exercise
these functions.
---
