[ https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231370#comment-17231370 ]
Lyor Goldstein commented on SSHD-1091: -------------------------------------- {quote} It seems to me the easiest way would be to merge sshd-common back into sshd-core. {quote} While it may be the easiest, I am not sure it is a good idea - it would revert us back to monolithic JAR(s), Personally I am inclined towards a 3.x version that would include the painful but probably necessary re-factoring. {quote} the split has always been a bit hazy (it is quite difficult to understand which class should go in which module) imho {quote} True, but basically my policy has been to put in {{sshd-core}} stuff that requires a client or server in order to run the tests and in {{sshd-common}} stuff that doesn't - e.g., loading/decoding key files does not require client/server, whereas testing port forwarding features does. > Java Module support > ------------------- > > Key: SSHD-1091 > URL: https://issues.apache.org/jira/browse/SSHD-1091 > Project: MINA SSHD > Issue Type: Improvement > Affects Versions: 2.5.1 > Reporter: Gili > Priority: Major > Labels: important > > Please use the mechanism found at > https://github.com/apache/maven-compiler-plugin/blob/master/src/it/multirelease-patterns/singleproject-runtime/pom.xml#L102-L108 > to build multirelease JAR that will provide module-info.java for users of > Java 9 and newer. > The current JAR triggers many problems for users of Java Modules and in fact > cannot be used at all in its current state due to > https://issues.apache.org/jira/browse/MCOMPILER-436 > This might be a bug in the Maven Compiler plugin but I suspect that > ultimately it will a problem with the library itself. For example, I noticed > that Apache Mina (which this library depends on) has split packages. Split > packages are incompatible with Java Modules. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org