[ https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17233766#comment-17233766 ]
Lyor Goldstein commented on SSHD-1091: -------------------------------------- {quote} Though I don't see the benefit of the current split. {quote} There is another benefit for the current split - handling key files, authorized keys, known hosts, raw ciphers/mac/compression etc. does not require any of the client/server specific code. {quote} I think we should split between common / client / server {quote} Agree - actually, I believe the split should be: * _sshd-common_ - same as current * _sshd-core_ - classes that are shared by client and server- e.g., {{Session}}, {{Channel}}, {{FactoryManager}}, etc. * _sshd-client_ - classes that are relevant only to the client - e.g., {{SshClient}}, {{ClientSession}}, {{ClientFactoryManager}}, etc. * _sshd-server_ - classes that are relevant only to the server - e.g., {{SshServer}}, {{ServerSession}}, {{ServerFactoryManager}}, etc. {quote} if we're going for a 3.0 version, we should think on how to reduce the footprint a bit as the sshd-osgi {quote} Agree - if we go for 3.0, then we could do the split along the lines I suggested and disband _sshd-osgi_ altogether. In this context, perhaps we should even consider a more fine grained split based on "optional components" - e.g. client/server port forwarding as separate module than core client/server (Not quite figured out if this is feasible, but a thought...) > Java Module support > ------------------- > > Key: SSHD-1091 > URL: https://issues.apache.org/jira/browse/SSHD-1091 > Project: MINA SSHD > Issue Type: Improvement > Affects Versions: 2.5.1 > Reporter: Gili > Priority: Major > Labels: important > > Please use the mechanism found at > https://github.com/apache/maven-compiler-plugin/blob/master/src/it/multirelease-patterns/singleproject-runtime/pom.xml#L102-L108 > to build multirelease JAR that will provide module-info.java for users of > Java 9 and newer. > The current JAR triggers many problems for users of Java Modules and in fact > cannot be used at all in its current state due to > https://issues.apache.org/jira/browse/MCOMPILER-436 > This might be a bug in the Maven Compiler plugin but I suspect that > ultimately it will a problem with the library itself. For example, I noticed > that Apache Mina (which this library depends on) has split packages. Split > packages are incompatible with Java Modules. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org