[
https://issues.apache.org/jira/browse/SSHD-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235289#comment-17235289
]
Guillaume Nodet commented on SSHD-1091:
---------------------------------------
I think the packages are already split in a logical manner: their name do
reflect where they belong. That's why we should split according to those
package names. The current split has proven to be difficult both from a
technical POV (it introduces split packages) and semantically (I'm not the only
one to think it is not intuitive), so I think we should go back on that and
keep:
- {{sshd-common}} for all {{org.apache.ssh.common.*}} packages
- {{ssd-client}} for all {{org.apache.ssh.client.*}} packages
- {{ssd-server}} for all {{org.apache.ssh.server.*}} packages
- {{ssd-agent}} for all {{org.apache.ssh.agent.*}} packages
- {{sshd-core}} : do not contain any packages, but contains all the tests and
has dependencies on all the above for backward compatibility
This will have the benefits of :
- remove the split packages (which is the original problem)
- keeping mostly backward compatible (i.e. the packages do not change),
people depending on {{sshd-core}} will continue without any problem
- align semantic / package naming
So in terms of actions to do, this means:
* create a {{ssh-client}} and {{sshd-server}} packages
* move packages from {{sshd-core}} to either {{sshd-common}}, {{sshd-client}}
or {{ssd-server}}
* fix everything ;)
> Java Module support
> -------------------
>
> Key: SSHD-1091
> URL: https://issues.apache.org/jira/browse/SSHD-1091
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: Gili
> Priority: Major
> Labels: important
>
> Please use the mechanism found at
> https://github.com/apache/maven-compiler-plugin/blob/master/src/it/multirelease-patterns/singleproject-runtime/pom.xml#L102-L108
> to build multirelease JAR that will provide module-info.java for users of
> Java 9 and newer.
> The current JAR triggers many problems for users of Java Modules and in fact
> cannot be used at all in its current state due to
> https://issues.apache.org/jira/browse/MCOMPILER-436
> This might be a bug in the Maven Compiler plugin but I suspect that
> ultimately it will a problem with the library itself. For example, I noticed
> that Apache Mina (which this library depends on) has split packages. Split
> packages are incompatible with Java Modules.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
