Anton, I don't think we need to add the Mac OS tests for 1.3.1 branch since travis CI is timing out and creates blockers, it also did not exist for v1.3.0.
On Thu, Nov 8, 2018 at 10:04 AM Anton Chernov <mecher...@gmail.com> wrote: > A PR to fix the tests: > > Remove test for non existing index copy operator (v1.3.x) > https://github.com/apache/incubator-mxnet/pull/13180 > > > Best > Anton > > чт, 8 нояб. 2018 г. в 10:05, Anton Chernov <mecher...@gmail.com>: > > > An addition has been made to include MacOS tests for the v1.3.x branch: > > > > [MXNET-908] Enable minimal OSX Travis build (v1.3.x) > > https://github.com/apache/incubator-mxnet/pull/13179 > > > > It includes following PR's for master: > > > > [MXNET-908] Enable minimal OSX Travis build > > https://github.com/apache/incubator-mxnet/pull/12462 > > > > [MXNET-908] Enable python tests in Travis > > https://github.com/apache/incubator-mxnet/pull/12550 > > > > [MXNET-968] Fix MacOS python tests > > https://github.com/apache/incubator-mxnet/pull/12590 > > > > > > Best > > Anton > > > > > > чт, 8 нояб. 2018 г. в 9:38, Anton Chernov <mecher...@gmail.com>: > > > >> Thank you everyone for your support and suggestions. All proposed PR's > >> have been merged. We will tag the release candidate and start the vote > on > >> Friday, the 9th of November 2018. > >> > >> Unfortunately after the merges the tests started to fail: > >> > >> http://jenkins.mxnet-ci.amazon-ml.com/job/incubator-mxnet/job/v1.3.x/ > >> > >> I will look into the failures, but any help as usual is very > appreciated. > >> > >> The nightly tests are fine: > >> http://jenkins.mxnet-ci.amazon-ml.com/job/NightlyTests/job/v1.3.x/ > >> > >> > >> Best > >> Anton > >> > >> > >> > >> > >> ср, 7 нояб. 2018 г. в 17:19, Anton Chernov <mecher...@gmail.com>: > >> > >>> Yes, you are right about the versions wording, thanks for > clarification. > >>> > >>> A performance improvement can be considered a bugfix as well. I see no > >>> big risks in including PR's by Haibin and Lin into the patch release. > >>> > >>> @Haibin, if you can reopen the PR's they should be good to go for the > >>> relase, considering the importance of the improvements. > >>> > >>> I propose the following bugfixes for the release as well (already > >>> created corresponding PR's): > >>> > >>> Fixed __setattr__ method of _MXClassPropertyMetaClass (v1.3.x) > >>> https://github.com/apache/incubator-mxnet/pull/13157 > >>> > >>> fixed symbols naming in RNNCell, LSTMCell, GRUCell (v1.3.x) > >>> https://github.com/apache/incubator-mxnet/pull/13158 > >>> > >>> We will be starting to merge the PR's shortly. If are no more proposals > >>> for backporting I would consider the list as set. > >>> > >>> Best > >>> Anton > >>> > >>> ср, 7 нояб. 2018 г. в 17:01, Sheng Zha <szha....@gmail.com>: > >>> > >>>> Hi Anton, > >>>> > >>>> I hear your concern about a simultaneous 1.4.0 release and it > certainly > >>>> is a valid one. > >>>> > >>>> Regarding the release, let’s agree on the language first. According to > >>>> semver.org, 1.3.1 release is considered patch release, which is for > >>>> backward compatible bug fixes, while 1.4.0 release is considered minor > >>>> release, which is for backward compatible new features. A major > release > >>>> would mean 2.0. > >>>> > >>>> The three PRs suggested by Haibin and Lin are all introducing new > >>>> features. If they go into a patch release, it would require an > exception > >>>> accepted by the community. Also, if other violation happens it could > be > >>>> ground for declining a release during votes. > >>>> > >>>> -sz > >>>> > >>>> > On Nov 7, 2018, at 2:25 AM, Anton Chernov <mecher...@gmail.com> > >>>> wrote: > >>>> > > >>>> > [MXNET-1179] Enforce deterministic algorithms in convolution layers > >>>> > >>> >
