jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename
TaskGroup to Task
URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455257
##########
File path:
runtime/common/src/main/java/edu/snu/nemo/runtime/common/state/TaskState.java
##########
@@ -32,48 +33,38 @@ private StateMachine buildTaskStateMachine() {
// Add states
stateMachineBuilder.addState(State.READY, "The task has been created.");
- stateMachineBuilder.addState(State.PENDING_IN_EXECUTOR, "The task is
pending in its executor.");
stateMachineBuilder.addState(State.EXECUTING, "The task is executing.");
- stateMachineBuilder.addState(State.COMPLETE, "The task's execution is
complete with its output committed.");
+ stateMachineBuilder.addState(State.COMPLETE, "All of this task's tasks
have completed.");
stateMachineBuilder.addState(State.FAILED_RECOVERABLE, "Task failed, but
is recoverable.");
- stateMachineBuilder.addState(State.FAILED_UNRECOVERABLE, "Task failed, and
is unrecoverable. The job will fail.");
+ stateMachineBuilder.addState(State.FAILED_UNRECOVERABLE,
+ "Task failed, and is unrecoverable. The job will fail.");
stateMachineBuilder.addState(State.ON_HOLD, "The task is paused for
dynamic optimization.");
+
// Add transitions
- stateMachineBuilder.addTransition(State.READY, State.PENDING_IN_EXECUTOR,
- "Scheduling for execution");
- stateMachineBuilder.addTransition(State.READY, State.FAILED_UNRECOVERABLE,
- "Unrecoverable TaskGroup Failure");
+ stateMachineBuilder.addTransition(State.READY, State.EXECUTING,
+ "Scheduling to executor");
stateMachineBuilder.addTransition(State.READY, State.FAILED_RECOVERABLE,
- "Recoverable TaskGroup Failure");
-
- stateMachineBuilder.addTransition(State.PENDING_IN_EXECUTOR,
State.EXECUTING,
- "Begin executing!");
- stateMachineBuilder.addTransition(State.PENDING_IN_EXECUTOR,
State.FAILED_UNRECOVERABLE,
- "Unrecoverable TaskGroup Failure/Executor Failure");
- stateMachineBuilder.addTransition(State.PENDING_IN_EXECUTOR,
State.FAILED_RECOVERABLE,
- "Recoverable TaskGroup Failure/Container Failure");
+ "Stage Failure by a recoverable failure in another task");
+ stateMachineBuilder.addTransition(State.READY, State.FAILED_UNRECOVERABLE,
+ "Stage Failure");
stateMachineBuilder.addTransition(State.EXECUTING, State.COMPLETE,
- "Task computation done");
+ "All tasks complete");
stateMachineBuilder.addTransition(State.EXECUTING,
State.FAILED_UNRECOVERABLE,
- "Unexpected failure/Executor Failure");
+ "Unrecoverable failure in a task/Executor failure");
stateMachineBuilder.addTransition(State.EXECUTING,
State.FAILED_RECOVERABLE,
- "Container Failure");
+ "Recoverable failure in a task/Container failure");
stateMachineBuilder.addTransition(State.EXECUTING, State.ON_HOLD, "Task
paused for dynamic optimization");
-
stateMachineBuilder.addTransition(State.ON_HOLD, State.COMPLETE, "Task
completed after dynamic optimization");
- stateMachineBuilder.addTransition(State.COMPLETE,
State.FAILED_UNRECOVERABLE,
- "Executor Failure");
-
stateMachineBuilder.addTransition(State.COMPLETE, State.FAILED_RECOVERABLE,
- "Container Failure");
+ "Recoverable failure in a task/Container failure");
+ stateMachineBuilder.addTransition(State.FAILED_RECOVERABLE, State.READY,
+ "Recoverable task failure");
Review comment:
"Task is ready from recoverable failure?"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
