jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename
TaskGroup to Task
URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456665
##########
File path:
runtime/master/src/test/java/edu.snu.nemo.runtime.master/scheduler/SourceLocationAwareSchedulingPolicyTest.java
##########
@@ -70,43 +70,43 @@ public void
testSourceLocationAwareSchedulingNotAvailable() {
public void testSourceLocationAwareSchedulingWithMultiSource() {
final SchedulingPolicy schedulingPolicy = new
SourceLocationAwareSchedulingPolicy();
// Prepare test scenario
- final ScheduledTaskGroup tg0 =
CreateScheduledTaskGroup.withReadablesWithSourceLocations(
+ final ScheduledTask tg0 =
CreateScheduledTask.withReadablesWithSourceLocations(
Collections.singletonList(Collections.singletonList(SITE_1)));
- final ScheduledTaskGroup tg1 =
CreateScheduledTaskGroup.withReadablesWithSourceLocations(
+ final ScheduledTask tg1 =
CreateScheduledTask.withReadablesWithSourceLocations(
Collections.singletonList(Arrays.asList(SITE_0, SITE_1, SITE_2)));
- final ScheduledTaskGroup tg2 =
CreateScheduledTaskGroup.withReadablesWithSourceLocations(
+ final ScheduledTask tg2 =
CreateScheduledTask.withReadablesWithSourceLocations(
Arrays.asList(Collections.singletonList(SITE_0),
Collections.singletonList(SITE_1),
Arrays.asList(SITE_1, SITE_2)));
- final ScheduledTaskGroup tg3 =
CreateScheduledTaskGroup.withReadablesWithSourceLocations(
+ final ScheduledTask tg3 =
CreateScheduledTask.withReadablesWithSourceLocations(
Arrays.asList(Collections.singletonList(SITE_1),
Collections.singletonList(SITE_0),
Arrays.asList(SITE_0, SITE_2)));
final ExecutorRepresenter e = mockExecutorRepresenter(SITE_1);
- for (final ScheduledTaskGroup tg : new HashSet<>(Arrays.asList(tg0, tg1,
tg2, tg3))) {
+ for (final ScheduledTask tg : new HashSet<>(Arrays.asList(tg0, tg1, tg2,
tg3))) {
assertEquals(new HashSet<>(Collections.singletonList(e)),
schedulingPolicy.filterExecutorRepresenters(
new HashSet<>(Collections.singletonList(e)), tg));
}
}
/**
- * Utility for creating {@link ScheduledTaskGroup}.
+ * Utility for creating {@link ScheduledTask}.
*/
- private static final class CreateScheduledTaskGroup {
- private static final AtomicInteger taskGroupIndex = new AtomicInteger(0);
+ private static final class CreateScheduledTask {
+ private static final AtomicInteger tgIndex = new AtomicInteger(0);
private static final AtomicInteger taskIndex = new AtomicInteger(0);
- private static ScheduledTaskGroup doCreate(final Collection<Readable>
readables) {
- final ScheduledTaskGroup mockInstance = mock(ScheduledTaskGroup.class);
+ private static ScheduledTask doCreate(final Collection<Readable>
readables) {
+ final ScheduledTask mockInstance = mock(ScheduledTask.class);
final Map<String, Readable> readableMap = new HashMap<>();
readables.forEach(readable -> readableMap.put(String.format("TASK-%d",
taskIndex.getAndIncrement()),
readable));
- when(mockInstance.getTaskGroupId()).thenReturn(String.format("TG-%d",
taskGroupIndex.getAndIncrement()));
+ when(mockInstance.getTaskId()).thenReturn(String.format("TG-%d",
tgIndex.getAndIncrement()));
Review comment:
"T-%d"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
