[GitHub] jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename TaskGroup to Task

[GitBox]

jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename 
TaskGroup to Task
URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189456068
 
 

 ##########
 File path: 
runtime/master/src/main/java/edu/snu/nemo/runtime/master/JobStateManager.java
 ##########
 @@ -131,36 +131,36 @@ private void initializeComputationStates() {
     physicalPlan.getStageDAG().topologicalDo(physicalStage -> {
       currentJobStageIds.add(physicalStage.getId());
       idToStageStates.put(physicalStage.getId(), new StageState());
-      physicalStage.getTaskGroupIds().forEach(taskGroupId -> {
-        idToTaskGroupStates.put(taskGroupId, new TaskGroupState());
+      physicalStage.getTaskIds().forEach(taskId -> {
+        idToTaskStates.put(taskId, new TaskState());
       });
     });
   }
 
   private void initializePartitionStates(final BlockManagerMaster 
blockManagerMaster) {
     final DAG<PhysicalStage, PhysicalStageEdge> stageDAG = 
physicalPlan.getStageDAG();
     stageDAG.topologicalDo(physicalStage -> {
-      final List<String> taskGroupIdsForStage = 
physicalStage.getTaskGroupIds();
+      final List<String> taskIdsForStage = physicalStage.getTaskIds();
       final List<PhysicalStageEdge> stageOutgoingEdges = 
stageDAG.getOutgoingEdgesOf(physicalStage);
 
       // Initialize states for blocks of inter-stage edges
       stageOutgoingEdges.forEach(physicalStageEdge -> {
-        final int srcParallelism = taskGroupIdsForStage.size();
+        final int srcParallelism = taskIdsForStage.size();
         IntStream.range(0, srcParallelism).forEach(srcTaskIdx -> {
           final String blockId = 
RuntimeIdGenerator.generateBlockId(physicalStageEdge.getId(), srcTaskIdx);
-          blockManagerMaster.initializeState(blockId, 
taskGroupIdsForStage.get(srcTaskIdx));
+          blockManagerMaster.initializeState(blockId, 
taskIdsForStage.get(srcTaskIdx));
         });
       });
 
       // Initialize states for blocks of stage internal edges
-      taskGroupIdsForStage.forEach(taskGroupId -> {
-        final DAG<Task, RuntimeEdge<Task>> taskGroupInternalDag = 
physicalStage.getTaskGroupDag();
-        taskGroupInternalDag.getVertices().forEach(task -> {
-          final List<RuntimeEdge<Task>> internalOutgoingEdges = 
taskGroupInternalDag.getOutgoingEdgesOf(task);
+      taskIdsForStage.forEach(taskId -> {
+        final DAG<Task, RuntimeEdge<Task>> taskInternalDag = 
physicalStage.getTaskDag();
 
 Review comment:
   taskInternalDAG -> taskDAG?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services