jeongyooneo commented on a change in pull request #20: [NEMO-76] Rename
TaskGroup to Task
URL: https://github.com/apache/incubator-nemo/pull/20#discussion_r189455394
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/Executor.java
##########
@@ -87,36 +87,36 @@ public String getExecutorId() {
return executorId;
}
- private synchronized void onTaskGroupReceived(final ScheduledTaskGroup
scheduledTaskGroup) {
- LOG.debug("Executor [{}] received TaskGroup [{}] to execute.",
- new Object[]{executorId, scheduledTaskGroup.getTaskGroupId()});
- executorService.execute(() -> launchTaskGroup(scheduledTaskGroup));
+ private synchronized void onTaskReceived(final ScheduledTask scheduledTask) {
+ LOG.debug("Executor [{}] received Task [{}] to execute.",
+ new Object[]{executorId, scheduledTask.getTaskId()});
+ executorService.execute(() -> launchTask(scheduledTask));
}
/**
- * Launches the TaskGroup, and keeps track of the execution state with
taskGroupStateManager.
- * @param scheduledTaskGroup to launch.
+ * Launches the Task, and keeps track of the execution state with
taskStateManager.
+ * @param scheduledTask to launch.
*/
- private void launchTaskGroup(final ScheduledTaskGroup scheduledTaskGroup) {
+ private void launchTask(final ScheduledTask scheduledTask) {
try {
- final DAG<Task, RuntimeEdge<Task>> taskGroupDag =
-
SerializationUtils.deserialize(scheduledTaskGroup.getSerializedTaskGroupDag());
- final TaskGroupStateManager taskGroupStateManager =
- new TaskGroupStateManager(scheduledTaskGroup, taskGroupDag,
executorId,
+ final DAG<Task, RuntimeEdge<Task>> taskDag =
+ SerializationUtils.deserialize(scheduledTask.getSerializedTaskDag());
+ final TaskStateManager taskStateManager =
+ new TaskStateManager(scheduledTask, taskDag, executorId,
persistentConnectionToMasterMap, metricMessageSender);
- scheduledTaskGroup.getTaskGroupIncomingEdges()
+ scheduledTask.getTaskIncomingEdges()
.forEach(e -> serializerManager.register(e.getId(), e.getCoder(),
e.getExecutionProperties()));
- scheduledTaskGroup.getTaskGroupOutgoingEdges()
+ scheduledTask.getTaskOutgoingEdges()
.forEach(e -> serializerManager.register(e.getId(), e.getCoder(),
e.getExecutionProperties()));
- // TODO #432: remove these coders when we "streamize" task execution
within a TaskGroup.
- taskGroupDag.getVertices().forEach(v -> {
- taskGroupDag.getOutgoingEdgesOf(v)
+ // TODO #432: remove these coders when we "streamize" task execution
within a Task.
Review comment:
Could you remove this comment?
This is related with #2, but it seems to be addressed via a separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
