johnyangk commented on a change in pull request #91: [NEMO-3] Bump up the Beam
version to 2.5.0
URL: https://github.com/apache/incubator-nemo/pull/91#discussion_r208195690
##########
File path:
compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/transform/CreateViewTransform.java
##########
@@ -52,8 +56,11 @@ public void prepare(final Context context, final
OutputCollector<O> oc) {
@Override
public void onData(final I element) {
- WindowedValue<I> data = WindowedValue.valueInGlobalWindow(element);
- windowed.add(data);
+ // Since CreateViewTransform takes KV(Void, value), this is okay
+ if (element instanceof KV) {
+ final KV<?, ?> kv = (KV<?, ?>) element;
+ multiView.getDataList().add(kv.getValue());
+ }
Review comment:
Just to double-check, can you do something like
else {
throw new IllegalStateException();
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
