johnyangk commented on a change in pull request #91: [NEMO-3] Bump up the Beam
version to 2.5.0
URL: https://github.com/apache/incubator-nemo/pull/91#discussion_r209157232
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/datatransfer/OutputCollectorImpl.java
##########
@@ -74,12 +77,24 @@ public void clearMain() {
}
public void clearTag(final String tag) {
- if (this.additionalTagElementsMap.get(tag) == null) {
+ if (this.mainTagOutputChildren.contains(tag)) {
// This dstVertexId is for the main tag
clearMain();
} else {
// Note that String#hashCode() can be cached, thus accessing additional
output queues can be fast.
this.additionalTagElementsMap.get(tag).clear();
}
}
+
+ public List<O> getMainTagOutputQueue() {
+ return mainTagElements;
+ }
+
+ public List getAdditionalTagOutputQueue(final String dstVertexId) {
+ if (this.mainTagOutputChildren.contains(dstVertexId)) {
+ return this.mainTagElements;
+ } else {
+ return this.additionalTagElementsMap.get(dstVertexId);
Review comment:
throw exception when the returned value is null for sanity check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
