johnyangk commented on a change in pull request #91: [NEMO-3] Bump up the Beam
version to 2.5.0
URL: https://github.com/apache/incubator-nemo/pull/91#discussion_r208193718
##########
File path:
examples/beam/src/main/java/edu/snu/nemo/examples/beam/GenericSourceSink.java
##########
@@ -94,7 +94,10 @@ public static PDone write(final PCollection<String>
dataToWrite,
dataToWrite.apply(ParDo.of(new HDFSWrite(path)));
return PDone.in(dataToWrite.getPipeline());
} else {
- return dataToWrite.apply(TextIO.write().to(path));
+ // Added withWindowedWrites() to local file writes. This is necessary
for FileResult coders.
+ // If not specified, FileResultCoder#encode will be blocked. See
windowCoder in FileResultCoder#encode
Review comment:
Can you elaborate on what 'blocked' means?
Does this mean compile-time translation failure, or run-time execution
failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
