johnyangk commented on a change in pull request #91: [NEMO-3] Bump up the Beam
version to 2.5.0
URL: https://github.com/apache/incubator-nemo/pull/91#discussion_r209156557
##########
File path:
compiler/frontend/beam/src/main/java/edu/snu/nemo/compiler/frontend/beam/BeamKeyExtractor.java
##########
@@ -26,7 +26,8 @@
@Override
public Object extractKey(final Object element) {
if (element instanceof KV) {
- return ((KV) element).getKey();
+ final Object key = ((KV) element).getKey();
+ return key == null ? 0 : key;
Review comment:
Leave a comment here that Beam allows KV(null, value)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
