I don't want to argue for squashed commits but for changing the commit history of pull request branches. From my point of view a commit should provide additional information about what changed. Having commits based on a code review like "fixed typo", "added review comment" there's no additional value at all. So why having these information in project history when it does not deliver any additional value?

Since resetting your local branch to latest remote version is not that hard it should not be a valid argument for not letting a contributor change the history of his commit.

--
Thanks
Benjamin

On 2019-11-19 03:10, Tim Boudreau wrote:
I really don't see the point of squashing commits. I know, everybody would like to look like they write perfect, concise, error-free code the first time. But nobody does - and that seems to be the primary purpose. If you want to see the set of changes that implement a feature, it's not that hard to come up with an incantation of git diff -r that will let you do that - and that kind of forensics as far less common - not something you should
contort your development process and spend work on to optimize.  So it
seems to me, the main point of making commit history pretty is ego. Which
is a silly thing to get excited about.

-Tim

Attachment: 0xDBDA3F83.asc
Description: application/pgp-keys

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to