Hi Eric, > Travis Master build has the same testing rule that a PR build has ? because > it's green and the sync to release too. Yes, and they are green because work has been done to get them green again. :-) The problem is the big bunch of PRs based on old master snapshots that where unstable in time of creation. That's the reason their Travis builds are broken. IMHO that makes it hard to check if they are ready to merge especially in your role as a release manager. That's the reason why I like to emphasize that people should have a look on their open PRs for periodically rebase. Less possible merging conflicts and more valid status concerning test status. I don't want to say that this is the only item to look after for taking the decision whether to merge or not. But it helps a lot.
> PR check doing only test is not enough. A pr with invalid mail, invalid name > should be flagged too before review code. It cost Matthias hours :p > Hector Espert do a lot of addition to travis test but I'm unsure the coverage > of travis test. There is still room for improvement. ;-) Kind regards, Benjamin On 02.05.2020 00:57, Eric Barboni wrote: > Hi, > > I agree with the big picture. But > > For what I encounter since 2 months I guess, travis job is not more re > triggerable (partial job too). > During 11.3 travis build had 1 download issue for 4 builds and was red for no > reason. So travis trust is low for me. > Travis Master build has the same testing rule that a PR build has ? because > it's green and the sync to release too. > > PR check doing only test is not enough. A pr with invalid mail, invalid name > should be flagged too before review code. It cost Matthias hours :p > Hector Espert do a lot of addition to travis test but I'm unsure the coverage > of travis test. > Best Regards > Eric > > -----Message d'origine----- > De : Neil C Smith <neilcsm...@apache.org> > Envoyé : vendredi 1 mai 2020 12:23 > À : dev <dev@netbeans.apache.org> > Objet : Re: About NetBeans build quality > > On Fri, 1 May 2020 at 09:32, Benjamin Graf <benjamin.g...@gmx.net> wrote: >> IMHO we all should have a look and taking more care after our PRs being >> green on Travis, too. Sometimes periodically rebasing against master does >> help getting green again if build is broken because of Travis bugs or >> someone else broken commits. > +1 And sometimes just retriggering Travis gets things working - to > pick up fixes in master, and there are a few spurious failures at times > unfortunately. > > My general approach when RM'ing was all PRs must be green before merging to > master, the sync PR from master to release branch must be green before > merging, and the release branch must be green before triggering a beta / > release build. > > This isn't a criticism of Eric's work here because I think aspects of the > Travis tests have been broken for a while now. Be good to get them back on > track, ideally before considering 12.0 release. > > Best wishes, > > Neil > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > >
signature.asc
Description: OpenPGP digital signature
