Build issues aside, I think the code in the PR actually needs at least a cursory review from someone else than the original author. Others, like myself, have passed by and tested the fix or left other comments, but I'm not sure anyone sat down and reviewed it all in one sitting.
( https://github.com/apache/netbeans/pull/2021 ) -- Eirik -----Original Message----- From: Ernie Rael <err...@raelity.com> Sent: Monday, January 11, 2021 12:34 PM To: dev@netbeans.apache.org Subject: Re: Profiling on 64bit Windows On 1/11/2021 6:53 AM, Geertjan Wielenga wrote: > What needs to be done? Can you provide a PR? Sadly no. I suspect that someone who knows their way around a distribution would have that knowledge. I could be wrong, but I suspect it's simple. If it is simple and it hasn't been done in two years, I'd guess it's more a lack of will or willingness to just check in the binaries. -ernie > > Gj > > On Mon, 11 Jan 2021 at 15:33, Ernie Rael <err...@raelity.com> wrote: > >> Hi all, >> >> There's been a fix for the 64 bit windows profiling problem for over >> two years. >> >> https://github.com/pedro-w/netbeans/releases/tag/v0.1-alpha >> https://issues.apache.org/jira/browse/NETBEANS-1428 >> >> AFAICT, it hasn't been integrated. There's some discussion every few >> months or so on how to get the binaries to be automatically built as >> part of the general build. An answer hasn't been found, so the >> problem remains. These binaries have been around and in use for quite a >> while. >> >> This issue seems stuck in the /Perfectionism is the enemy of >> progress/ trap. >> >> Can't the binaries be checked in and included, while the >> investigation for a solution proceeds? >> >> -ernie >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org >> For additional commands, e-mail: dev-h...@netbeans.apache.org >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
