I think we as a community need to fix the "native builds" issue very soon. PRs are piling up.
This current email thread is not the only one. Over the past 2 years fixes have been made (PRs merged) to native binaries code in the areas of * Native Launchers * NBI (installers) * Profiler launcher The problem is the same in all cases: The“source code is fixed but there's never a new binary being build hence nothing really happens. These binaries were never re-build in an Apache NetBeans setting. They were simply copied from their old Oracle-era location to https://netbeans.osuosl.org/binaries from where they are picked up by the Apache NetBeans build process but labelled as something which has a CDDL license. This is legally correct but is a limbo state: The source code is (now) owned by ASF but for reason of lack of time we are still using the pre-ASF binaries. I can 100% understand why such "shortcut" was made and salute those who made it happen. However, obviously it is sub-optimal that parts of the NetBeans Platform and IDE distribution effectively cannot be bug-fixed. The right solution IMHO is that those parts of the Apache NetBeans universe would be a first-class citizen in the general Jenkins build pipeline for the Platform and IDE distribution. By first-class I mean that the binary is automatically re-build whenever the source code changes. This would require Jenkins build slaves for Linux, MacOS and Windows (which I understand that ASF indeed has) and it would probably require quite a bit of setup work to get right. Apache NetBeans is a Java-oriented community so knowledge about building C/C++ binaries is limited which is probably why nobody so far is stepping forward. As Ernie suggests there may be a short term solution too which is more quick-and-dirty i.e. someone would re-build locally, verify the binaries and then upload as one-shot fix. However it is not always that simple. The binaries are distributed as one ZIP. If one decides to only re-build the binary for the Windows platform then this current packaging breaks down because then you have one binary in the ZIP which is ASF and the others which are CCDL and no longer build from the same revision in the VCS. It would be a mess. Therefore, in many ways, I'm not sure the quick-and-dirty solution really exists. Is this a correct status ? Lars On Tue, Jan 12, 2021 at 2:07 AM Eirik Bakke <[email protected]> wrote: > > Build issues aside, I think the code in the PR actually needs at least a > cursory review from someone else than the original author. Others, like > myself, have passed by and tested the fix or left other comments, but I'm not > sure anyone sat down and reviewed it all in one sitting. > > ( https://github.com/apache/netbeans/pull/2021 ) > > -- Eirik > > -----Original Message----- > From: Ernie Rael <[email protected]> > Sent: Monday, January 11, 2021 12:34 PM > To: [email protected] > Subject: Re: Profiling on 64bit Windows > > On 1/11/2021 6:53 AM, Geertjan Wielenga wrote: > > What needs to be done? Can you provide a PR? > > Sadly no. I suspect that someone who knows their way around a distribution > would have that knowledge. I could be wrong, but I suspect it's simple. > > If it is simple and it hasn't been done in two years, I'd guess it's more a > lack of will or willingness to just check in the binaries. > > -ernie > > > > > > Gj > > > > On Mon, 11 Jan 2021 at 15:33, Ernie Rael <[email protected]> wrote: > > > >> Hi all, > >> > >> There's been a fix for the 64 bit windows profiling problem for over > >> two years. > >> > >> https://github.com/pedro-w/netbeans/releases/tag/v0.1-alpha > >> https://issues.apache.org/jira/browse/NETBEANS-1428 > >> > >> AFAICT, it hasn't been integrated. There's some discussion every few > >> months or so on how to get the binaries to be automatically built as > >> part of the general build. An answer hasn't been found, so the > >> problem remains. These binaries have been around and in use for quite a > >> while. > >> > >> This issue seems stuck in the /Perfectionism is the enemy of > >> progress/ trap. > >> > >> Can't the binaries be checked in and included, while the > >> investigation for a solution proceeds? > >> > >> -ernie > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > >> For further information about the NetBeans mailing lists, visit: > >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > >> > >> > >> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
