El 9/1/22 a las 0:10, Matthias Bläsing escribió:
before the whole module tree is changed, I would go with the least
intrusive change, which is Option 1 (only the layer is changed).
Very sensible, as usual. Thanks Matthias! :-).
From Jan's reply in this thread, it seems we'll have to recover the
cnd.debugger.* modules from contrib and do some heavy refactoring of
modules...
This can either be done by moving from annotiaton to a manually written
layer file or by changing the annotation processor, to support the
weight attribute. I would be willing to do the changes of the
annotation processor, if that is the chosen way.
Your wish is my command! :-)
https://github.com/apache/netbeans/pull/3432
Here we go with a manually written layer.xml file (well, copied from the
generated one and with a "weight" attribute added).
I think that modifying the @OptionsPanelController and
@OptionsPanelController.SubRegistration annotations (including an
optional "weight" integer attribute with default value 0) and updating
the annotation processor is the way to go.
It would be great if you go on with the changes (possibly in "master"
before is frozen, we can always merge into "cnd" later on).
Lets not introduce dependencies where there are none. And if I read the
comments about weight in the filesystem module, this looks like the
intention of the introduction of the weight attribute.
Yes, that was the original goal of
https://bz.apache.org/netbeans/show_bug.cgi?id=141925 : to avoid
introducing weird dependencies.
As a seondary benefit: adding support for the "weight" attribute may be
of use by people trying to contribute to Apache NetBeans by adding their
panes to the OptionsPanelController without requiring weird
dependencies/friendships.
So, to summarize, I think the plan could go as follows:
OPTION 1 (Matthias', Antonio's):
Go through the least intrusive change as much as we can. Optionally add
support for the "weight" attribute in the annotations/annotation processor.
OPTION 4 (Jan's, Neil's):
Recover the "cnd.debugger.*" modules from the contrib directory,
possibly reviewing dependencies, and integrate cpplite cluster modules
into cnd, double-checking with Martin Entlicher.
We aligned now?
Thanks & kind regards,
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
