On Sun, Jan 9, 2022 at 10:15 AM antonio <[email protected]> wrote: > > > El 9/1/22 a las 0:10, Matthias Bläsing escribió: > > before the whole module tree is changed, I would go with the least > > intrusive change, which is Option 1 (only the layer is changed). > > Very sensible, as usual. Thanks Matthias! :-). > > From Jan's reply in this thread, it seems we'll have to recover the > cnd.debugger.* modules from contrib and do some heavy refactoring of > modules... >
Surely not the whole modules - only about ~20 files (after/if/when we do cleanup, even less would likely remain): org/netbeans/modules/cnd/debugger/gdb2/GdbLogger.java org/netbeans/modules/cnd/debugger/gdb2/GdbVersionPeculiarity.java org/netbeans/modules/cnd/debugger/gdb2/GdbUtils.java org/netbeans/modules/cnd/debugger/gdb2/mi/MIConst.java org/netbeans/modules/cnd/debugger/gdb2/mi/MIUserInteraction.java org/netbeans/modules/cnd/debugger/gdb2/mi/package.html org/netbeans/modules/cnd/debugger/gdb2/mi/MITListItem.java org/netbeans/modules/cnd/debugger/gdb2/mi/MICommandInjector.java org/netbeans/modules/cnd/debugger/gdb2/mi/MIRecord.java org/netbeans/modules/cnd/debugger/gdb2/mi/MIValue.java org/netbeans/modules/cnd/debugger/gdb2/mi/MICommandManager.java org/netbeans/modules/cnd/debugger/gdb2/mi/MIParser.java org/netbeans/modules/cnd/debugger/gdb2/mi/MITList.java org/netbeans/modules/cnd/debugger/gdb2/mi/MIProxy.java org/netbeans/modules/cnd/debugger/gdb2/mi/MICommand.java org/netbeans/modules/cnd/debugger/gdb2/mi/Log.java org/netbeans/modules/cnd/debugger/gdb2/mi/MIResult.java org/netbeans/modules/cnd/debugger/common2/utils/LogSupport.java org/netbeans/modules/cnd/debugger/common2/utils/StopWatch.java org/netbeans/modules/cnd/debugger/common2/debugger/remote/Platform.java This is basically the low-level interaction with GDB, the integration into the IDE is written in a different way in cpplite.debugger. As these files were donated, it does not make much sense (IMO) to try to re-write them, we only need to take them through the IP Clearance with the rest of the code. Jan > > > > This can either be done by moving from annotiaton to a manually written > > layer file or by changing the annotation processor, to support the > > weight attribute. I would be willing to do the changes of the > > annotation processor, if that is the chosen way. > > Your wish is my command! :-) > > https://github.com/apache/netbeans/pull/3432 > > Here we go with a manually written layer.xml file (well, copied from the > generated one and with a "weight" attribute added). > > I think that modifying the @OptionsPanelController and > @OptionsPanelController.SubRegistration annotations (including an > optional "weight" integer attribute with default value 0) and updating > the annotation processor is the way to go. > > It would be great if you go on with the changes (possibly in "master" > before is frozen, we can always merge into "cnd" later on). > > > > > Lets not introduce dependencies where there are none. And if I read the > > comments about weight in the filesystem module, this looks like the > > intention of the introduction of the weight attribute. > > Yes, that was the original goal of > https://bz.apache.org/netbeans/show_bug.cgi?id=141925 : to avoid > introducing weird dependencies. > > As a seondary benefit: adding support for the "weight" attribute may be > of use by people trying to contribute to Apache NetBeans by adding their > panes to the OptionsPanelController without requiring weird > dependencies/friendships. > > > > So, to summarize, I think the plan could go as follows: > > OPTION 1 (Matthias', Antonio's): > > Go through the least intrusive change as much as we can. Optionally add > support for the "weight" attribute in the annotations/annotation processor. > > OPTION 4 (Jan's, Neil's): > > Recover the "cnd.debugger.*" modules from the contrib directory, > possibly reviewing dependencies, and integrate cpplite cluster modules > into cnd, double-checking with Martin Entlicher. > > We aligned now? > > Thanks & kind regards, > Antonio > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
