> I just don't think that changing the design of the tabs (particularly making 
> them not flat) is the way to fix it.  

Well, one question to consider is: Why are the window system tabs flat in the 
first place? They always looked like proper tabs until NetBeans 13. Is the 
"flat" design really better?

One source of confusion may be due to the fact that "FlatLAF" has "flat" in its 
name. But a lot of the advantages we get from FlatLAF--it's high level of 
polish, customizability, cross-platform yet native-looking feel--are unrelated 
to the look of the window system tabs in particular. 

Another point: I did a survey of other IDE-like apps that have tabs in their 
window systems (see screenshots in https://github.com/apache/netbeans/pull/3115 
) , and the current NetBeans style resembles only one of them, namely IntelliJ. 
Which makes sense, since FlatLAF was originally meant to mimic the IntelliJ 
theme. But now that NetBeans uses FlatLAF as its default, it is less desirable, 
from a branding perspective, to try to copy the visual style of a "competing" 
IDE.

--- Eirik

-----Original Message-----
From: Neil C Smith <neilcsm...@apache.org> 
Sent: Friday, June 24, 2022 11:12 AM
To: dev@netbeans.apache.org
Subject: Re: FlatLAF tab style discussion

On Fri, 24 Jun 2022 at 10:46, Eirik Bakke <eba...@ultorg.com> wrote:
> With FlatLAF becoming the default look & feel since NetBeans 13, the tab 
> components in the window system (over editors and sidebars) no longe resemble 
> tabs, and are somewhat difficult to see. The proposed PR fixes this, by 
> introducing a new look for the tabs that shows the selected tab as a proper 
> tab while leaving a simplified flattened look for unselected tabs.

To be clear, considering my -0, I totally agree with the visibility point.  
This needs fixing, and I think the tabbed pane UI in FlatLaf has an 
accessibility issue here anyway.  I just don't think that changing the design 
of the tabs (particularly making them not flat) is the way to fix it.  I think 
the colour palette needs more contrast / accenting.  You can see this in some 
of the other software screenshots you shared there.  You can also see it in 
menus, option categories, etc.

I would also say I do think the PR should probably be merged.  I was hoping 
Karl might have some thoughts on fixing some of the issues in a way that more 
aligns with other areas of FlatLaf, but we can always tweak further afterwards 
...

Best wishes,

Neil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to