Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/272#issuecomment-196089886
i was reviewing this earlier today and frankly had a similar concern to
this as Adam. I didn't reply because I hadn't really figured out what to
think. First, I agree that a service which rejects that header is arguably
broken. Second, as the patch is right now I am curious how it works when the
value is empty string because there is a static call to MediaType.... which
seems like it would have trouble (still need to verify the logic there though).
However, having said this Pierre can you clarify if the intent is only for
the case where there is no entity body or is it also for when there is an
entity body in the request? If the idea is that this is only necessary when
there is no entity body we should tighten the code for that case and if it is
for either scenario then I think i'm of similar mind to Adam here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
