Github user taftster commented on a diff in the pull request:
https://github.com/apache/nifi/pull/272#discussion_r56928547
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -215,14 +215,24 @@
.build();
public static final PropertyDescriptor PROP_CONTENT_TYPE = new
PropertyDescriptor.Builder()
- .name("Content-Type")
- .description("The Content-Type to specify for when content is
being transmitted through a PUT or POST. "
- + "In the case of an empty value after evaluating an
expression language expression, Content-Type defaults to " +
DEFAULT_CONTENT_TYPE)
- .required(true)
- .expressionLanguageSupported(true)
- .defaultValue("${" + CoreAttributes.MIME_TYPE.key() + "}")
- .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
- .build();
+ .name("Content-Type")
+ .description("The Content-Type to specify for when content is
being transmitted through a PUT or POST. "
+ + "In the case of an empty value after evaluating an
expression language expression, Content-Type defaults to " +
DEFAULT_CONTENT_TYPE + "."
+ + "If and only if body is not sent, Content-Type must
be set to empty")
+ .required(false)
+ .expressionLanguageSupported(true)
+ .defaultValue("${" + CoreAttributes.MIME_TYPE.key() + "}")
+
.addValidator(StandardValidators.createAttributeExpressionLanguageValidator(AttributeExpression.ResultType.STRING))
+ .build();
+
+ public static final PropertyDescriptor PROP_SEND_BODY = new
PropertyDescriptor.Builder()
+ .name("Send body")
+ .description("True if the body content should be sent, false
otherwise")
+ .defaultValue("true")
--- End diff --
We should refer to this as the HTTP spec refers to it. It's called the
"message-body" in the spec, so I think we should use that here as well. i.e.
```
.name("send-message-body")
.displayName("Send Message Body")
.description("If true, sends the HTTP message body on POST/PUT requests
(default). If false, suppresses the message body and content-type header for
these requests.")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
