Thanks sir. I skimmed the wiki, we have almost the same opinion. For a feature branch, we just use same workflow, the only different is that the PR is against the feature branch, not master or dev.
And on merging the branch back, for HBase and Hadoop, we will start a vote in the mailing list. And for me, I will create a big PR on GitHub to let users review the final changes, although no one can review it all but users can review the part he/she interested. And also a design doc will help. And finally if no objections, we can merge the feature branch back. From my understanding, there is no '3 more +1s' rule here, as if someone does not want this to be merged, this means we still have some works to do. I do not have the permission to update the wiki so just post things here. Thanks. Gregory Nutt <spudan...@gmail.com> 于2019年12月27日周五 上午8:47写道： > Hi Duo > > For complex feature, in Hadoop and HBase and related big data projects > I’ve > > seen in ASF, we will create a feature branch, and then open PRs against > > this branch. And since it is not master, you are free to apply even half > > done PR if the full one is too large. And finally when you are done, > start > > a vote to merge it back. > > > > Usually we will open an issue on jira, and create a sub task for each > > commit of the branch, and the branch also follow the PR-Review-Merge > > workflow. > > > > What David said many times, open a PR and then everyone push to update > the > > PR, I will not define it as our official workflow. You are free to use > what > > you like to develop a feature in your own repo, but when you want to > merge > > it back, you open a PR and do what every contributor should do. > > As I mentioned in a previous email, I proposed some English for the > feature branch requirements at the bottom of > > https://cwiki.apache.org/confluence/display/NUTTXTEST/Code+Contribution+Workflow+--+Brennan+Ashton > > What I wrote there is essentially the same that you are saying here. > You are welcome to review and comment at that URL (which will be moving > when the website is moved to its final home). > > Greg > > >
