Like Michael, I also prefer to include the work into the code base and test it over there. It seems like you put a lot of effort into this code so thank you! I like the fact that you brought all the artifacts into the theme along with the FTL macros. This is a good first step, and I believe continuing on this direction is where we need to go.
+1 to committing into the code base and testing over there. On Fri, Aug 18, 2017 at 1:09 AM, Jacques Le Roux <jacques.le.r...@les7arts.com> wrote: > That sounds great, > > Thanks Nicolas! > > Jacques > > > Le 17/08/2017 à 22:00, Nicolas Malin a écrit : >> >> Hello, >> >> I started the documentation here >> https://github.com/nmalin/ofbiz-framework/blob/common-theme/themes/README.md >> >> It's a begging, I hope improve it quickly >> >> Nicolas >> >> >> Le 16/08/2017 à 13:49, Nicolas Malin a écrit : >>> >>> Hello; >>> >>> To continue the common-theme subject, I haven't see negative return to >>> the issue Create a common theme (OFBIZ-9138) [1] and on threads on the same >>> subject [2] and the additional theme xml definition [3], I suggest to create >>> a documentation on the wiki how work the "theme engine" and commit the >>> current git branch [4] [5] on trunk >>> >>> After that, the engine will be present on the trunk and we continue the >>> work to : >>> * Clean the common-theme and create a real theme >>> * Migrate properly the current theme with the new structure >>> * Analyze more how organize the screen api >>> >>> But don't panic, before that I'm listening to all suggest or remarks ;) >>> >>> Nicolas >>> >>> [1] https://issues.apache.org/jira/browse/OFBIZ-9138 >>> [2] >>> https://lists.apache.org/thread.html/6ab61eb5ddeb4669f6e8e15fff44db724a596ecfece34ba4e34ef490@%3Cdev.ofbiz.apache.org%3E >>> [3] >>> https://lists.apache.org/thread.html/8c40f261d2d818aed6f38abe231030204f8f8d6ca8a366b9f040f326@%3Cdev.ofbiz.apache.org%3E >>> [4] https://github.com/nmalin/ofbiz-framework/tree/common-theme >>> [5] >>> https://github.com/apache/ofbiz-framework/compare/trunk...nmalin:common-theme?expand=1 >>> >>> >> >> >
