Since it depends on the good will of scrutinizer/s and varies in errors depending on context, I suggest that we add a "gradlew check" step in our Builbot trunk framework builder.

Then everyone will be aware of this feature and we will be able to adjust the 
maxErrors as needed. Actually I'm still waiting for INFRA-19443 for that...

Jacques

Le 25/11/2019 à 11:18, Jacques Le Roux a écrit :
Here with Gitbox plugins I have 37790 errors and when using 
pullAllPluginsSource (ie using svn with Github) I have 37857 errors

In both case it's more than /tasks.checkstyleMain.maxErrors = 37779/

I don't understand why we have all these differences (34563 errors for you Nicolas) when 
we are supposed to use the same "trunk HEAD"

Jacques

Le 25/11/2019 à 09:17, Nicolas Malin a écrit :
I run the check with success from my part but with 34563 errors, I suppose that 
it's not only mine :)

Nicolas

On 23/11/2019 17:07, Mathieu Lirzin wrote:
I recently pulled the latest commit, and I noticed that latest commits
have introducted linting issues.

Since a521de9ad8a0b5a0f9ceadab348c46d7961ff89a ‘gradlew check’ fails.

Pawan Verma, Nicolas Malin and Jacques Le Roux can you fix the java code
you have written to conform to OFBiz coding style ?

Thanks.



Reply via email to