Hi all, +1 to INFRA-20314.
Committer should install a checkstyle plugin in the IDE pointing to our checkstyle.xml. This helps to highlight Lint errors so that style issues can be corrected early. Regards, James On 2020/06/05 17:30:18, Jacques Le Roux <jacques.le.r...@les7arts.com> wrote: > Hi All, > > Since then we also created INFRA-20314 > > At OFBIZ-11304 Aditya suggested something else. To use a Gradle plugin to add > pre-commit hook. > > I tested it, it does not prevent a committer to push changes even if they > increase the number of check style issues. > > I'd like to know what the community prefers: > > * Prevent a committer to push changes even if they increase the number of > check style issues. This implies to implement INFRA-20314 > * Allows a committer to push changes even if they increase the number of > check style issues. Then we could use OFBIZ-11304 only. > > What do you think? If we can get to a consensus we might start a vote > > Thanks > > Jacques > > Le 03/12/2019 à 09:42, Jacques Le Roux a écrit : > > Hi Nicolas, > > > > Great, I think we should use it as a team, nobody against? > > > > Jacques > > > > Le 03/12/2019 à 09:21, Nicolas Malin a écrit : > >> I haven't plugin installed, only famework. > >> > >> Thanks for your sharing a will use that. > >> > >> Nicolas > >> > >> On 02/12/2019 17:32, Jacques Le Roux wrote: > >>> Le 30/11/2019 à 08:58, Jacques Le Roux a écrit : > >>>> I think we should rely on a Checkstyle pre-commit hook: > >>>> https://gist.github.com/davetron5000/37350 to complement > >>>> tasks.checkstyleMain.maxErrors > >>>> > >>>> So every committer would have it installed locally and the problem would > >>>> be gone \o/ > >>>> > >>>> What do people think? > >>>> > >>>> Jacques > >>> I created https://issues.apache.org/jira/browse/OFBIZ-11304 for that > >>> > >>> Jacques > >>> > >>> > >> > > >
