Hi Michael/Jacques +1 for the proposal. However, I do not face this issue on my local, partly because I never tried to push to the repository without running any gradle command. The gitHook gradle plug-in is essentially creating hooks on the local repository that's why when I push to my forked OFBiz repo, pre-push hook always gets executed forcing me to conform to checkstyle standards on my forked repo too.
Best Regards, Girish On Thu, Feb 4, 2021 at 1:34 PM Jacques Le Roux <jacques.le.r...@les7arts.com> wrote: > Le 03/02/2021 à 17:59, Michael Brohl a écrit : > > So I think we should find a way to deploy the hooks to the user's local > repository to make sure they are used there also. Else we would always > chase > > after newly introduced checkstyle problems, especially if we use pull > requests. > > > > I found a solution here: > https://www.viget.com/articles/two-ways-to-share-git-hooks-with-your-team/ > (at the bottom of the page). This must be > > adapted for Gradle to be dependend of a build. > > > > This would keep our hooks versioned in the repository and would > automatically install the hooks in the local repository. > > > > What do you think? > > Hi Michael, > > It looks like a good idea to me. A Jira would fit. > > In the meantime you need to fix the checkstyle issues put in with > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1973 > details here: > > https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins/builds/1973/steps/check/logs/stdio > > TIA > > Jacques > >
