Comments Inline :- On Fri, Jul 11, 2008 at 2:15 AM, Bruno Busco <[EMAIL PROTECTED]> wrote:
> Ashish, > thank you for your comments. > Well, of course if the themes are taken from the gallery there should be a > information on the theme that tells you with which release of Ofbiz it can > be used (now we could go with the SVN rev until we have the next release). > If this is the case that you are thinking then I am fine with the desired approach. > > For the file overwritting we could think to have the theme in a special > folder (this is how many CMS do, for example Drupal). > So for example we could have: > /framework/images/webapp/images/themes/theme1/maincss.css > /framework/images/webapp/images/themes/theme2/maincss.css +1 > > > the themesX folder should never be committed. And then have a UI that let > us > specify which theme between the availables must be used (this, as > suggested, > could be in the user preferences). > +1 > > -Bruno > > > 2008/7/11 Ashish Vijaywargiya <[EMAIL PROTECTED]>: > > > Sorry for writing again on this. > > But I see a loopwhole in this. > > > > Suppose you are creating new maincss.css file. > > Someone has downloaded your file and kept your file in images directory > and > > removes the old one. > > Now if user take update of Ofbiz on regular basis or we can say after > > certain duration of time. > > And if someone introduce a new class in Stylesheet file and uses it > > extensively in some section so in this > > case your file(maincss.css created by you) might not be having those new > > classes entries. > > So the layout will not be consistent. > > > > What do you think about it Bruno ? > > > > -- > > Ashish > > > > > > > > On Fri, Jul 11, 2008 at 1:49 AM, Ashish Vijaywargiya < > > [EMAIL PROTECTED]> wrote: > > > > > Bruno, > > > > > > I like your idea. > > > > > > -- > > > Ashish > > > > > > > > > On Fri, Jul 11, 2008 at 1:37 AM, Bruno Busco <[EMAIL PROTECTED]> > > > wrote: > > > > > >> Hi devs, > > >> I am writing a new maincss.css file and I will submit when finished. > > >> > > >> I think that several other users/developers will write (or have > already) > > >> their .css files. > > >> Since the graphical theme is something very subjective it will be > > >> difficult > > >> to agree with a unique theme and have it committed on SVN. > > >> So I propose to open a OFBiz Theme Gallery on confluence where all > users > > >> can > > >> upload their own theme with a little screenshot. > > >> All users could then browse the available theme, download it and copy > on > > >> their ofbiz installation. > > >> > > >> The standard theme format to uploaded could be a folder that contains > > the > > >> maincss.css file and relative gif files. > > >> > > >> What do you think about? > > >> > > >> Many thanks, > > >> Bruno > > >> > > > > > > > > >
