Hi Jacques,
You're right, I completely forgot to replace the tabs before submitting
the patch. Sorry for that. I'll change it and forward the corrected patch.
Regards,
Karim
Jacques Le Roux (JIRA) wrote:
[ https://issues.apache.org/jira/browse/OFBIZ-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12648155#action_12648155 ]
Jacques Le Roux commented on OFBIZ-2046:
----------------------------------------
Karim,
I had a look at your patch. There are at least 2 issues :
* Please don't use tabs in your patches but 4 spaces (please read
http://docs.ofbiz.org/display/OFBADMIN/OFBiz+Contributors+Best+Practices)
* Actually I would have commited your patch as is since it's easy to replace
tabs by 4 spaces in an editor. But I would prefer that you update your patch
before. There have been some changes since and it will be easier for me than to
check all files to be merged
Thanks
more and improved spanish translations
--------------------------------------
Key: OFBIZ-2046
URL: https://issues.apache.org/jira/browse/OFBIZ-2046
Project: OFBiz
Issue Type: Improvement
Components: accounting, content, ecommerce, framework, humanres,
manufacturing, marketing, order, party, product, workeffort
Affects Versions: SVN trunk
Environment: any
Reporter: Karim Rahimpur
Attachments: spanish_translations.patch
This patch adds spanish translations, corrects errors in spanish translations
and improves existing ones.
These files have substantial amounts of translations added or improved:
- PartyEntityLabels.xml
- PartyUiLabels.xml
- ManufacturingUiLabels.xml
- OrderEntityLabels.xml
- OrderErrorUiLabels.xml
- OrderUiLabels.xml
- PartyEntityLabels.xml
- PartyUiLabels.xml
- ProductEntityLabels.xml
- ProductUiLabels.xml
Minor additions/improvements in other files.
Note: overall, there are a lot more additions than improvements.
About some of the improvements:
In general these translations are changed, reasons given:
- "orden" which is quite a literal translation of "order" has been replaced by
"pedido"
- request was translated as "pedido" which actually means order, this is replaced by
"petición"
- quote was translated as "cotización" and is replaced by "presupuesto" which
is more commonly used
- (of quantities) "publicada" replaced by "emitida" as it corresponds more to
"issued"
- "seleccionar" (picking within facilities) is translated as "recoger" more appropriate
for "pick"
- "monto" where expressing an amount is translated as "importe" following the
more common use
- "reporte" as the literal translation of "report", though valid, more properly
translated as "informe"
- requirement was translated as "requerimiento" (a judicial term) and is replaced by
"requisito" as it expresses clearly a need
Of course, these may depend on region so any comments are welcome.
------------------------------------------------------------------------
No virus found in this incoming message.
Checked by AVG - http://www.avg.com
Version: 8.0.175 / Virus Database: 270.9.4/1795 - Release Date: 17/11/2008 17:24
