Hello Jacques, The following changes are good: - <request-map uri="FindSubscriptionResource"><security https="true" auth="true"/><response name="success" type="view" value="FindSubscriptionResource"/></request-map> - <request-map uri="EditSubscriptionResource"><security https="true" auth="true"/><response name="success" type="view" value="EditSubscriptionResource"/></request-map> + <request-map uri="FindSubscriptionResource"> + <security https="true" auth="true"/> + <response name="success" type="view" value="FindSubscriptionResource"/> + </request-map> + <request-map uri="EditSubscriptionResource"> + <security https="true" auth="true"/> + <response name="success" type="view" value="EditSubscriptionResource"/> + </request-map>
*But* I don't like the changes for moving "invoke" attribute to the new line: - <event type="java" path="org.ofbiz.product.product.ProductEvents" invoke="updateProductQuickAdminShipping"/> + <event type="java" path="org.ofbiz.product.product.ProductEvents" + invoke="updateProductQuickAdminShipping"/> And for view map entries - +1. -- Ashish On Thu, Nov 19, 2009 at 6:44 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > > Hi devs, > > I often found myself in difficulties when reading controllers files. > > I would like to format them all as it's done on the attached example > http://n4.nabble.com/file/n623986/controller.patch controller.patch , but > the view-maps which I would prefer to keep on one line. > > Opinions ? > > Thanks > > Jacques > -- > View this message in context: > http://n4.nabble.com/Formatting-controllers-tp623986p623986.html > Sent from the OFBiz - Dev mailing list archive at Nabble.com. >
